Add option in /proc/cmdline to enable/disable the generator #43
Conversation
|
Anaconda folks have decided to deprecate inst.zram and leave it up to zram-generator folks if there's a use case for command line inhibition. |
|
In that case, I think it is not worth implementing some option to disable it. |
Yeah, I think its "defaultness" (the state of whether it is or is not enabled by default) is so fundamental to the image in question that it must be correct. |
|
I think it'd be worthwhile to have a kernel-commandline option. I'm not sure about the name though. |
|
|
|
Updated with |
keszybz
changed the title
src/main.rs
Outdated
| @@ -65,14 +65,22 @@ fn main() -> Result<()> { | |||
|
|
|||
| let _ = kernlog::init_with_level(log_level); | |||
|
|
|||
| let kernel_override = || match config::kernel_zram_option(root) { | |||
| Some(false) => std::process::exit(0), | |||
There was a problem hiding this comment.
sth like {info!("Disabled by kernel cmdline option"); return Ok(())} would be better
There was a problem hiding this comment.
But that'd just return from the closure, no?
There was a problem hiding this comment.
Oh, I'd missed the closure part; IIRC the log is explicitly flushed, so even though "no destructors on the current stack or any other thread's stack will be run", an info!(); exit(0) should be fine, if imperfect, but all alternatives I came up with are even uglier, so.
keszybz
force-pushed
the
anaconda-compat
branch
from
bfd3076
to
41ff670
Compare
|
Pfff, time flies. Updated with a few minor typo fixes and |
keszybz
force-pushed
the
anaconda-compat
branch
from
41ff670
to
80fb430
Compare
See the man page diff for description of semantics.
Looking at the confusion in https://bugzilla.redhat.com/show_bug.cgi?id=1861463, I think it's always good to be very explicit where some file came from.
keszybz
force-pushed
the
anaconda-compat
branch
from
80fb430
to
fa8ea44
Compare
|
... and rebased. |
Closes #42.