Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversing for cardinal directions in relation member roles #2004

Closed
wants to merge 1 commit into from

Conversation

mvexel
Copy link
Contributor

@mvexel mvexel commented Nov 21, 2013

This adds smart reversing for north<->south and east<->west in relation member roles when reversing a way.

@jfirebaugh
Copy link
Member

Thanks, committed as c43d915.

@jfirebaugh jfirebaugh closed this Nov 21, 2013
@simonpoole
Copy link
Contributor

Long done deed I know. But I fail to see why this would make sense, why would the cardinal direction role of a member of a relation change when the (OSM) way direction changes? Contrary to forward/backward the use as a member of route with the role north, south, etc is not relative to the ways drawing direction.

@bhousel
Copy link
Member

bhousel commented Jul 26, 2018

@simonpoole This is probably a case where iD does a thing because JOSM also does it. We link to the JOSM code in a comment, and my reading of it is that it reversed the "Combined switchers" when reversing relation roles.

https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/corrector/ReverseWayTagCorrector.java#L265

@simonpoole
Copy link
Contributor

Even JOSM devs are known to be wrong now and then :-)

bhousel added a commit that referenced this pull request Aug 5, 2018
@bhousel
Copy link
Member

bhousel commented Aug 5, 2018

I've removed the cardinal direction reversals in 2e6799a
Per https://twitter.com/bhousel/status/1025805098063208448 it looks like JOSM will stop doing this too. Thanks @simonpoole

@HolgerJeromin
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants