-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump docker-api crate to git ref #2903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhelwig
approved these changes
Oct 26, 2023
Confirmed expected fix is in downstream package:
Confirmed via |
bors merge |
Build succeeded: |
nickgerace
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR description too! We need more of these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-buck2-resources
A-bytes-lines-codec
A-config-file
A-council
A-cyclone
Area: Function execution engine [Rust]
A-dal
A-dal-test
A-deadpool-cyclone
Area: Pooling support for Cyclone instances [Rust]
A-module-index
A-nats-subscriber
A-object-tree
A-pinga
A-sdf
Area: Primary backend API service [Rust]
A-si-data-nats
A-si-data-pg
A-si-pkg
A-si-posthog-rs
A-si-settings
Area: Backend service settings management [Rust]
A-si-std
A-si-test-macros
A-telemetry-application-rs
A-telemetry-rs
A-veritech
Area: Task execution backend service [Rust]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: Discord issue regarding issues with SI Launcher.
Bump models to v1.43 was merged into the docker-api crate on 10th June
The commit/change never made it into the crate itself, being last published on 5th June (0.14.0): There isn't a version of this crate with the updated option config in it
To that end, moved to using a git reference off HEAD for the build.
NB: It's noteworthy we have two different crates for docker-api interaction across our monorepo: bollard and docker-api. I suggest at some point we consolidate these/use the most common one.
Added
:si
build target for Buck for convenience