Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump docker-api crate to git ref #2903

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

johnrwatson
Copy link
Contributor

Ref: Discord issue regarding issues with SI Launcher.

Bump models to v1.43 was merged into the docker-api crate on 10th June
The commit/change never made it into the crate itself, being last published on 5th June (0.14.0): There isn't a version of this crate with the updated option config in it

To that end, moved to using a git reference off HEAD for the build.

NB: It's noteworthy we have two different crates for docker-api interaction across our monorepo: bollard and docker-api. I suggest at some point we consolidate these/use the most common one.

Added :si build target for Buck for convenience

~/D/RISCOSPi.5.28 > si update
System Initiative Launcher is in "local" mode


The application panicked (crashed).
Message:  Unable to push events to Posthog: ()
Location: bin/si/src/main.rs:166

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
Error: 
   0: docker api: missing field `VirtualSize` at line 1 column 1626
   1: missing field `VirtualSize` at line 1 column 1626

Location:
   bin/si/src/main.rs:138

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

@johnrwatson
Copy link
Contributor Author

Confirmed expected fix is in downstream package:

    /// Total size of the image including all layers it is composed of.
    ///
    /// In versions of Docker before v1.10, this field was calculated from
    /// the image itself and all of its parent images. Images are now stored
    /// self-contained, and no longer use a parent-chain, making this field
    /// an equivalent of the Size field.
    ///
    /// Deprecated: this field is kept for backward compatibility, and will be removed in API v1.44.
    pub virtual_size: Option<i64>,

Confirmed via buck2 run //bin/si <commands> that the CLI still functions at a basic level/no major regressions

@johnrwatson
Copy link
Contributor Author

bors merge

@si-bors-ng
Copy link
Contributor

si-bors-ng bot commented Oct 26, 2023

Build succeeded:

@si-bors-ng si-bors-ng bot merged commit d461b03 into main Oct 26, 2023
9 checks passed
@si-bors-ng si-bors-ng bot deleted the feat/reissue-docker-api-crate branch October 26, 2023 17:24
Copy link
Contributor

@nickgerace nickgerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR description too! We need more of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants