Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

Builder as a class #44

Closed
guybedford opened this issue Jan 13, 2015 · 5 comments · Fixed by #69
Closed

Builder as a class #44

guybedford opened this issue Jan 13, 2015 · 5 comments · Fixed by #69

Comments

@guybedford
Copy link
Member

We should change builder itself to be a class that is created with config, so that we don't pollute the global build environment.

@crisptrutski
Copy link
Contributor

@guybedford how do suggest we isolate the System.config calls being eval'd by loadConfig?

Will System also need to exposes class instances?

@crisptrutski
Copy link
Contributor

Nevermind, see your trick just above.

@guybedford
Copy link
Member Author

Suggested API ideas:

  var Builder = require('builder');
  var builder = new Builder('./cfg' / {cfg});
  builder.config();
  builder.buildTree();
  builder.build();
  // .. etc ..

@guybedford
Copy link
Member Author

@crisptrutski ^

@crisptrutski
Copy link
Contributor

@guybedford let's merge + bump?

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants