This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
Builder class #69
Merged
Builder class #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes test cases to drive automatic pickup of source maps from sourceMapURL comments, if we decided to add that feature.
This also fixes a bug in the tests, and the relevant 6to5 fixture has been updated to demonstrate the issue with paths. Moved and renamed source map expectations to make more sense.
Old code can be retained with `.legacy` to get back their desired shared state etc. Constructor overloaded to take config path or object
For the love of the chainers.
crisptrutski
force-pushed
the
builder-class
branch
from
16382ec
to
b077ca1
Compare
|
@guybedford decrapified the history |
|
Awesome, thanks. Let me review very soon for merge. |
Merged
|
Beautiful! Merge away. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44