Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Change the field types for Pcuser and create utility functions #107

Closed
mish24 opened this issue Feb 22, 2017 · 2 comments
Closed

Change the field types for Pcuser and create utility functions #107

mish24 opened this issue Feb 22, 2017 · 2 comments

Comments

@mish24
Copy link

mish24 commented Feb 22, 2017

Currently the field types are as follows

  1. title - CharField
  2. phone - CharField
  3. location - CharField
  4. gender - CharField

I want to change the field types and add regex validators too. Then it would be easier to write tests for user as well.
Also, I think it would be nice if there were utility tests added which could create posts, users and pcusers on their own. We can use them at once and just add mock data rather than writing everything again and again. @medhach Can I go ahead?
@medhach
Copy link

medhach commented Feb 22, 2017

Sure, send in a PR soon!

@medhach medhach closed this as completed Feb 22, 2017
@mish24
Copy link
Author

mish24 commented Feb 22, 2017

On it!

@mish24 mish24 mentioned this issue Feb 27, 2017
Merged
medhach added a commit that referenced this issue Mar 1, 2017
@medhach
Merge pull request #163 from mish24/new_utils
268160d 
Added utility functions and tests for signup (#107)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@medhach @mish24