This repository has been archived by the owner on Nov 8, 2018. It is now read-only.
Added the Contribution Guide to docs (fix for #102) #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mish24
force-pushed
the
contribution
branch
2 times, most recently
from
db4b9a5
to
d8a957d
Compare
medhach
reviewed
Feb 24, 2017
docs/Contribution.md
Outdated
| Set up a branch for a particular set of changes and switch to it: | ||
|
|
||
| `$ git checkout -b my_branch` | ||
| `$ git checkout my_branch` |
There was a problem hiding this comment.
Doesn't git checkout -b my_branch take you into my_branch? I think this line could be removed. :)
medhach
reviewed
Feb 24, 2017
docs/Contribution.md
Outdated
|
|
||
| `$ git checkout -b my_branch` | ||
| `$ git checkout my_branch` | ||
|
|
There was a problem hiding this comment.
And maybe you should also mention that a request can be pulled without creating a new branch explicitly. That would be 1 request at a time, but its still a good option I think. :)
medhach
reviewed
Feb 24, 2017
docs/Contribution.md
Outdated
|
|
||
| The instructions given below are for software developers who want to work on [our current code](https://github.com/systers/macc). | ||
|
|
||
| ## Git workflow |
There was a problem hiding this comment.
How about this order?
- What to work on
- Coding standards(styles)
- Git workflow
There was a problem hiding this comment.
Git workflow should be explained first I suppose?
Then what to work on, and the guidelines to follow (coding styles)
mish24
force-pushed
the
contribution
branch
2 times, most recently
from
7c3ec4e
to
756ec4e
Compare
|
@medhach Ma'am I changed the file according to what you suggested. Order is
|
changes new changes new changes2 new changes3 new changes4 Final commit Added a separate contribution file to docs new change Added a separate contribution guide to docs type fix Added a separate Contribution Guide to docs updated readme made certain edits Added a separate contribution file and updated README final edits Added a separate contribution guide to docs
|
Great job! Thanks for working on this, we needed it! |
|
Thanks a lot :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives information about how to set up remote, keep the origin and upstream synced, styling guidelines to follow, necessary steps while sending PRs. Addresses issue #102 @medhach Please review ma'am.