-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
// SocialMediaController.swift | ||
// malaria-ios | ||
// | ||
// Created by Eric Huang on 1/10/16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this information from your classes
Moreover, sync with master :) |
The runtime error is from not being able to import XCTest. I created that file from an old repo so I think that is causing the error. Remaking the file should fix it though. |
SocialShareAbleTest was unable to import XCTest because it was made from a different repository. Remaking the file fixes this issue. SocialShareAbleTest was also renamed to TestSocialShareAble to be more aligned with the other unit tests in the project.
This one first good first step for social integration. @Dwar3xwar , can you add touch events to the Stat buttons to trigger share? It seems that you have everything except that. This is what you intended, correct? Regarding the rest 👍 |
Yup that was my intention but I just wasn't sure how to approach the user experience. The stat buttons make a lot of sense though haha |
Stat labels now have touch events. They will present an alert controller to ask a user to pick the social media they want to share on.
The goal is to make the share method use SocialShareable more intutive. It will now show messages from the message variable of the SocialShareable object.
Hey there @Dwar3xwar , I only saw the updates now! :( Well, the app crashes on iPad but I have a fix for that: Regarding the rest everything looks great. |
Just for the sake of completness:
The fix for that issue is the above comment |
@bphenriques No problem at all. We all have busy schedules :) I didn't think of testing on the iPad, but good catch! Seems like there is a conflict with the merge. As this is my first time doing a pull request, I'm not sure how to see what the conflicts are. |
You probably have to sync your branch :) http://stackoverflow.com/questions/7244321/how-to-update-a-github-forked-repository |
SocialShareAbleTest was unable to import XCTest because it was made from a different repository. Remaking the file fixes this issue. SocialShareAbleTest was also renamed to TestSocialShareAble to be more aligned with the other unit tests in the project.
Stat labels now have touch events. They will present an alert controller to ask a user to pick the social media they want to share on.
The goal is to make the share method use SocialShareable more intutive. It will now show messages from the message variable of the SocialShareable object.
I am not sure about what you did but recheck your sync with our systers branch (https://github.com/systers/malaria-app-ios/commits/develop) so that we are able to merge the pull request,. Afterwards, resubmit the pull request again. It would be great accepting this pull request. Don't give up! My suggestion:
|
Fixed branch to develop.