Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Modifying AboutView Controller #243

Closed
4 tasks
SIMRAN1 opened this issue Mar 23, 2018 · 17 comments · Fixed by #401
Closed
4 tasks

Modifying AboutView Controller #243

SIMRAN1 opened this issue Mar 23, 2018 · 17 comments · Fixed by #401
Assignees
Labels
Port from Android Identify features needing to be ported from the Android version.

Comments

@SIMRAN1
Copy link
Contributor

SIMRAN1 commented Mar 23, 2018

Description

As a developer,
I want to change the about screen so that the android and iOS version of app will be consistent..

Mocks

image

Acceptance Criteria

When About Screen is made consistent with android.

Update [Required]

  • [LIST ITEMS]

Enhancement to Update [Optional]

  • [LIST ITEMS]

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

4 hours

@SIMRAN1
Copy link
Contributor Author

SIMRAN1 commented Mar 23, 2018

@sunjunkie mam and @zenara mam please approve this issue.

@sunjunkie
Copy link
Contributor

We do want consistency between Android and iOS apps. However, we also want to adhere to the standard UI practices in each ecosystem. So an iOS screen does not need to be a mirror image of the corresponding Android screen but instead should provide the same information but keep the look and feel of iOS and Apple guidelines.
The screen shot above does not feel like an iOS App (e.g., the arrows). Also, what happens when the text is clicked?

@sunjunkie
Copy link
Contributor

Also, fix the user story to conform to the format: "As a developer,
I want to change the about screen so that the android and iOS version of app will be consistent."

@SIMRAN1
Copy link
Contributor Author

SIMRAN1 commented Mar 28, 2018

okk @sunjunkie mam I will fix the template.I really apologise for this mistake.
When the user clicks the text this happens.
image
@sunjunkie mam shall we discuss about this screen design in slack??.

@sunjunkie
Copy link
Contributor

You can work on the About page text display - displaying titles and then expanding the text when the title is tapped. Don't use alerts. Let's also change the titles to be consistent with each other.

What is Powerup?
Why is Powerup needed?
How does Powerup help teenagers?

@SIMRAN1
Copy link
Contributor Author

SIMRAN1 commented Mar 29, 2018

okk @sunjunkie mam I will send a pr for this.

@justkd justkd added the Port from Android Identify features needing to be ported from the Android version. label Jul 27, 2018
@MANI14011998
Copy link

MANI14011998 commented Feb 23, 2020

@sunjunkie ma'am i am work on this issue .i will give pr tomorrow

@sunjunkie
Copy link
Contributor

@MANI14011998 OK.

@anubhavpulkit
Copy link
Contributor

@sunjunkie I think AboutView looks more beautiful if the description is in one body only. And describe our idea is fewer words.

@MANI14011998
Copy link

MANI14011998 commented Feb 25, 2020

@AnubhavSingh16 I am currently working On this Issue and send the Pull request As Well
if you wants to add some more idea you can mention on pr or wait until my pr accepted

@anubhavpulkit
Copy link
Contributor

anubhavpulkit commented Feb 25, 2020

@MANI14011998 I cannot send PR. I just give my suggestion I think its help you and organisation the same time.

@anubhavpulkit
Copy link
Contributor

@sunjunkie Can I work on this issue.

@sunjunkie
Copy link
Contributor

You have a couple other issues to tackle first.

@anubhavpulkit
Copy link
Contributor

Ok, @sunjunkie I work on this issue after completion of all pending issues. Thank You @sunjunkie

@sunjunkie
Copy link
Contributor

OK. Please also see the discussion on PR #348.

@sunjunkie
Copy link
Contributor

@AnubhavSingh16 you can work on this.

@anubhavpulkit
Copy link
Contributor

anubhavpulkit commented Mar 17, 2020

Thank you @sunjunkie

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Port from Android Identify features needing to be ported from the Android version.
Projects
None yet
5 participants