Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Enhancement of AboutViewController #348

Closed
wants to merge 8 commits into from

Conversation

MANI14011998
Copy link

@MANI14011998 MANI14011998 commented Feb 24, 2020

Description

Enhancement of AboutViewController

Fixes [#243 ]

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface
  • Outreach

MockUp

WhatsApp Image 2020-02-25 at 12 59 16 AM
WhatsApp Image 2020-02-25 at 1 04 47 AM

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules
  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Tested On simulator

Code On

  • AboutViewController
  • Added TableView and Extension
  • Added collapsed Feature In there
  • Created AboutViewController.swift
  • TableViewDeleGate for changing in tableView
  • Created aboutTableViewCell
  • edited String.swift

Get To Know/Personal Achievement

  • String.swift
  • Structure of PowerUp
  • Gets idea about future proposal
  • Style Guideline
  • Guidance with mentors

@MANI14011998
Copy link
Author

@justkd @sunjunkie please review and if It need Change Please tell

@sunjunkie sunjunkie self-requested a review February 25, 2020 05:40
@sunjunkie
Copy link
Contributor

This looks good but the initial view should have all 3 sections collapsed (as you show in your first screenshot above) so that it is immediately obvious that there are 3 sections of information.

@MANI14011998
Copy link
Author

Ohk sure I will change that with in 10 mins

@MANI14011998
Copy link
Author

@sunjunkie please have a look

@sunjunkie
Copy link
Contributor

That'a good but I noticed that the text of the 3rd heading does not fit. You'll need to redesign this so that all the heading text fits. (I tested on iphone 8 and 8 plus)

@MANI14011998
Copy link
Author

Can you send me sreenshot so that I will understand more !

@sunjunkie
Copy link
Contributor

Simulator Screen Shot - iPhone 8 Plus - 2020-02-25 at 01 11 48

@MANI14011998
Copy link
Author

Ohhh got it

@MANI14011998
Copy link
Author

MANI14011998 commented Feb 25, 2020

@sunjunkie ma'am review that

@sunjunkie
Copy link
Contributor

@MANI14011998 I've been merging PRs finally. However, there is a conflict now with your PR. Can you resolve this and resubmit? Thanks.

@sunjunkie
Copy link
Contributor

@MANI14011998 Can you please resolve the conflicts in this PR? Otherwise, I must make this issue available to someone else.

@sunjunkie sunjunkie mentioned this pull request Mar 15, 2020
4 tasks
@sunjunkie sunjunkie closed this Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants