Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#175 Code Organisation in the Repo #183

Merged
merged 1 commit into from
May 23, 2018
Merged

Issue#175 Code Organisation in the Repo #183

merged 1 commit into from
May 23, 2018

Conversation

BaaniLeen
Copy link
Member

@BaaniLeen BaaniLeen commented May 18, 2018

Description

In this PR I have set up a basic angular app.

Fixes #175 & #132

Type of Change:

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I have tested it by running it on localhost using the command npm install , ng serve -o & observing the website on http://localhost:4200/ .

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • Any dependent changes have been published in downstream modules

Copy link
Member

@divyanshu-rawat divyanshu-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CLI Generated Boilerplate Code for intial setup.

@Tharangi
Copy link

@BaaniLeen: This runs on http://localhost:4200/ right? Make sure you update the Readme with it.

@Tharangi
Copy link

Tharangi commented May 23, 2018

Sorry I just saw! That is in your next PR. :)

@Tharangi Tharangi merged commit 00bf1fc into systers:gsoc18-code May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants