Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port program page #239

Merged
merged 4 commits into from
Jul 15, 2018
Merged

Port program page #239

merged 4 commits into from
Jul 15, 2018

Conversation

BaaniLeen
Copy link
Member

@BaaniLeen BaaniLeen commented Jul 12, 2018

Description

As a contributor,
I need port the existing program page to the new codebase.

Fixes #234

Can be merged only after #225. (To have minimum Merge conflicts I built on top of it)

Time taken = 5 hours (Including trying to resolve the conflicts manually on the GSOC18 branch, was unable to do that, and then finally resorting to building the code on top of #225)

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface
  • Outreach

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Ran it locally.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@BaaniLeen
Copy link
Member Author

@ancyp @janiceilene @Tharangi @kanmodi In order to test the PR locally, you would have to do npm install as well as npm i @ng-bootstrap/ng-bootstrap since the package.json file has been changed (and the changes are not yet merged in the gsoc18-code branch).

@ancyp
Copy link
Contributor

ancyp commented Jul 15, 2018

@BaaniLeen
Resolve conflict let's merge this first

@BaaniLeen
Copy link
Member Author

@ancyp Resolved the merge conflict. Can we merge it?

@ancyp ancyp merged commit db29fe1 into systers:gsoc18-code Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants