Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Home Page Button Bug #253

Merged
merged 4 commits into from
Jul 25, 2018
Merged

Fixed Home Page Button Bug #253

merged 4 commits into from
Jul 25, 2018

Conversation

BaaniLeen
Copy link
Member

@BaaniLeen BaaniLeen commented Jul 23, 2018

Description

Fixed the home page button renavigation bug.

Fixes #251

Time Taken:

1 hour

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Ran it locally.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

Copy link
Contributor

@bethanyr bethanyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BaaniLeen - are there supposed to be footer card changes as part of this PR? The title says it's just to fix the home page button.

@BaaniLeen
Copy link
Member Author

@bethanyr It is perhaps because of me resolving a merge conflict with the PR which fixed the View details button at the bottom of each card.

@BaaniLeen
Copy link
Member Author

@bethanyr Can you please review this PR?

@bethanyr bethanyr merged commit 64b9d5b into systers:gsoc18-code Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants