Avoid count()ing NULL
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2023
Closed
|
@jensschuppe #180 is absolutely fine for me, and it's pretty clear that you know your codebase much better than I do! When will release 2.3 be published? |
jensschuppe
force-pushed
the
countCountable
branch
from
68afb45
to
aede56d
Compare
jensschuppe
force-pushed
the
countCountable
branch
from
aede56d
to
f0f79d3
Compare
|
@bjendres a quick review? And any concerns releasing this as a |
|
I have tested #180 and it works well. And, releasing as 2.2.1 would be perfect! |
jensschuppe
added
status:reviewed and tested
jensschuppe
added a commit
that referenced
this pull request
Oct 11, 2023
jensschuppe
added
status:fixed
|
Released with version |
pminf
reviewed
Nov 6, 2023
| CRM_Utils_System::url( | ||
| 'civicrm/donrec/task', | ||
| 'sid=' . $result['snapshot']->getId() | ||
| . '&ccount=' . count($this - $this->getContactIDs()) |
There was a problem hiding this comment.
@jensschuppe I think this calculation is not intended and will cause a type error in PHP 8.
There was a problem hiding this comment.
Thanks for spotting that, I released 2.2.3 with that being fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178 by not trying to
count()potentially not initialized$this->_contactIdsin task forms and use$this->getContactIDs()instead which has a null-coalesce guard with a default value of[].