Set 'None' select option values to empty string instead of 0

systopia · Apr 3, 2020 · f304f4c · f304f4c · jensschuppe · Apr 3, 2020
1 parent 7222d5f
commit f304f4c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/CRM/Admin/Form/Mutualaid.php b/CRM/Admin/Form/Mutualaid.php
@@ -77,7 +77,7 @@ public function buildQuickForm()
                     array(
                         'text' => E::ts('- None -'),
                         'attr' => array(
-                            'value' => 0,
+                            'value' => '',
                         ),
                     )
                 );

diff --git a/CRM/Mutualaid/Form.php b/CRM/Mutualaid/Form.php
@@ -201,7 +201,7 @@ public function addContactFormFields()
                 case 'suffix_id':
                     $options = array();
                     if (!$required) {
-                        $options[0] = E::ts('- None -');
+                        $options[''] = E::ts('- None -');
                     }
                     $options += CRM_Contact_BAO_Contact::buildOptions(
                         $field_name

diff --git a/CRM/Mutualaid/Settings.php b/CRM/Mutualaid/Settings.php
@@ -296,7 +296,7 @@ public static function getCountries($include_none = true)
     {
         $countries = array();
         if ($include_none) {
-            $countries[0] = E::ts('- None -');
+            $countries[''] = E::ts('- None -');
         }
         $countries += CRM_Admin_Form_Setting_Localization::getAvailableCountries();
 
@@ -307,7 +307,7 @@ public static function getStateProvinces($country_id = null, $include_none = tru
     {
         $state_provinces = array();
         if ($include_none) {
-            $state_provinces[0] = E::ts('- None -');
+            $state_provinces[''] = E::ts('- None -');
         }
 
         if (!isset($country_id)) {
@@ -329,7 +329,7 @@ public static function getCounties($state_province_id = null, $include_none = tr
     {
         $counties = array();
         if ($include_none) {
-            $counties[0] = E::ts('- None -');
+            $counties[''] = E::ts('- None -');
         }
 
         if (!isset($state_province_id)) {