Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required select fields accept "- None -" etc. as valid option #21

Closed
jensschuppe opened this issue Apr 3, 2020 · 4 comments
Closed

Required select fields accept "- None -" etc. as valid option #21

jensschuppe opened this issue Apr 3, 2020 · 4 comments
Assignees
@jensschuppe
Labels
bug Something isn't working
Milestone
1.0

Comments

@jensschuppe
Copy link
Contributor

This produces errors like '0' is not a valid option for field county_id.

This applies to those fields:

  • prefix_id
  • suffix_id
  • county_id
  • state_province_id
  • country_id

The extension uses 0 as value for those "- None -" or "- Select -" options. Instead, the empty string '' should be used.
@jensschuppe jensschuppe added the bug Something isn't working label Apr 3, 2020
@jensschuppe jensschuppe added this to the 1.0 milestone Apr 3, 2020
@jensschuppe jensschuppe self-assigned this Apr 3, 2020
@jensschuppe
Copy link
Contributor Author

Forgot to crosslink commit f304f4c

jensschuppe referenced this issue Apr 3, 2020
@jensschuppe
Set 'None' select option values to empty string instead of 0
f304f4c
jensschuppe added a commit that referenced this issue Apr 3, 2020
@jensschuppe
[#21] Set 'None' select option values to empty string instead of 0
00360e3
jensschuppe added a commit that referenced this issue Apr 3, 2020
@jensschuppe
Merge branch 'issue/21'
eb0c26f 
[#21] Required select fields accept "- None -" etc. as valid option
@jensschuppe
Copy link
Contributor Author

Released with 1.0-beta2 and merged into master for the next 1.1.x release.

@bjendres
Copy link
Member

bjendres commented Apr 3, 2020

Has also been released in 1.1.

@jensschuppe can we close this?

@jensschuppe
Copy link
Contributor Author

Sure, that seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensschuppe jensschuppe

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@bjendres @jensschuppe