This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
Enhance "remove_query()" to Recognize Other Ampersand Forms #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove_query() strips out the WP Query String name-value pair, if it exists. But because it can exist by starting with either "?" or "&" it forgot to also check for other forms of the ampersand such as WP's &\#38; and \&
amiga-500
changed the title
szepeviktor
pushed a commit
that referenced
this pull request
May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
remove_query()function strips out the WP Query String name-value pair (e.g., ver=4.#.#), if it exists. But because this name-value pair can start with either ? or & the previous code did not take into account the other forms of ampersand that WP passes to this function. Namely, &# 038; and &. These other forms were indeed being passed toremove_query()but were not being recognized until now.