This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
Debug Mode Not Working #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiga-500
added a commit
that referenced
this pull request
Feb 21, 2017
This is related to #405 .. somehow i forgot to include this changed file too when pushing the others so here it is now.
amiga-500
added a commit
that referenced
this pull request
Feb 21, 2017
This is related to #405 .. somehow i forgot to include this changed file too when pushing the others so here it is now.
szepeviktor
pushed a commit
that referenced
this pull request
May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Debug Mode feature is a great way to help get more information when trying to figure out why a page isn't working. However, there were a few issues:
When using CDN or Minify, and enabling their respective debugging option, those specific debug information summary outputs did not display in the page footer.
If a user had opted to support W3TC (via the admin popup, a string can get assigned to
common.supportor a boolean of true can be assigned tocommon.tweeted) and then decided to use the debug mode, no debug information would show in the footer for any caching feature.When supporting W3TC the intention is to only hide the: Performance optimized by W3 Total Cache. Learn more: http://www.w3-edge.com/products/ text display line that appears in page footers for users who have not opted into supporting W3TC, but by doing so it incorrectly also took away the debug information entirely (if debug mode was used) for those who did opt-in.
Both problems outlined above are now fixed in this patch.