Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Projector / FabQR feature #692

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

mgmax
Copy link
Collaborator

@mgmax mgmax commented Nov 19, 2023

The feature for QR code scanning and projector output was no longer usable because it depended on a really old PHP script for age-old PHP versions.

Still needs some practical testing: In an earlier version, sending laser jobs was completely broken. Now there might be some other issues remaining.

The feature for QR code scanning and projector output was no longer usable because it depended on a really old PHP script for age-old PHP versions.
@mgmax mgmax marked this pull request as ready for review December 20, 2023 18:38
@mgmax mgmax mentioned this pull request Feb 7, 2024
Copy link
Contributor

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look and built a version with the suggested changes. Looks good to me. I think it's a brilliant idea to remove features that have not been used in practice since their original implementation (in this case, 9 years ago as part of some thesis).

@mgmax mgmax merged commit 734a6fc into t-oster:master Mar 3, 2024
@mgmax mgmax deleted the remove-projector-feature branch March 3, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants