Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input :focus box-shadow colour #58

Closed
mwanji opened this issue Dec 12, 2014 · 5 comments
Closed

Input :focus box-shadow colour #58

mwanji opened this issue Dec 12, 2014 · 5 comments

Comments

@mwanji
Copy link

mwanji commented Dec 12, 2014

As far as I can tell, the colour of a focused input's box-shadow is hardcoded to rgba(82, 168, 236, 0.6).

With bootstrap.less, you can modify the colour with @input-border-focus. Would it be possible to add this functionality?

I modified it in the following way for my project, but do not know this project and LESS well enough to know if this is a safe change:

.select2-container-active .select2-choice,
.select2-container-multi.select2-container-active .select2-choices {
  @color-rgba: rgba(red(@input-border-focus), green(@input-border-focus), blue(@input-border-focus), .6);
  border-color: @input-border-focus;
  outline: none;
  @shadow: inset 0 1px 1px rgba(0, 0, 0, 0.075), 0 0 8px @color-rgba;
  .box-shadow(@shadow);
  @transition: border-color ease-in-out .15s, box-shadow ease-in-out .15s;
  .transition(@transition);
}
@mwanji mwanji changed the title Input :focus colour Input :focus box-shadow colour Dec 12, 2014
@fk
Copy link
Collaborator

fk commented Dec 12, 2014

Thank you @mwanji – that's a good catch! (I'm a little baffled as to why this is hardcoded … :/)
Will fix this ASAP, but it might take me until tomorrow.

@fk fk added the bootstrap3 label Dec 12, 2014
@mwanji
Copy link
Author

mwanji commented Dec 12, 2014

That's great, thanks!

fk pushed a commit to fk/select2-bootstrap-css that referenced this issue Dec 14, 2014
@fk fk mentioned this issue Dec 14, 2014
@fk
Copy link
Collaborator

fk commented Dec 14, 2014

Should be fixed in v1.4.4 – I tested both Sass and Less versions, but since I'm a little distracted today, could you please test and close this issue yourself if this works for you?

@mwanji
Copy link
Author

mwanji commented Dec 15, 2014

Yes, it's working great now, thanks!

@mwanji mwanji closed this as completed Dec 15, 2014
@fk
Copy link
Collaborator

fk commented Dec 15, 2014

Yay! Thanks again! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants