4.0.0-pre.3 with Issue #15 Add a dummy setter for observeParams property

t2ym · Mar 2, 2019 · f29349f · f29349f
1 parent cbef17d
commit f29349f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/i18n-format.js b/i18n-format.js
@@ -268,6 +268,9 @@ export class I18nFormat extends polyfill(HTMLElement) {
   get observeParams() {
     return true;
   }
+  set observeParams(value) {
+    console.warn(`${this.is}: observeParams is deprecated and has a read-only dummy value true.`);
+  }
 
   connectedCallback() {
     this.render();

diff --git a/package.json b/package.json
@@ -18,7 +18,7 @@
   },
   "homepage": "https://github.com/t2ym/i18n-format#readme",
   "name": "i18n-format",
-  "version": "4.0.0-pre.2",
+  "version": "4.0.0-pre.3",
   "main": "i18n-format.js",
   "directories": {
     "test": "test"

diff --git a/test/basic-test.html b/test/basic-test.html
@@ -364,6 +364,8 @@
     test('default observeParams property', function () {
       assert.isBoolean(el.observeParams, 'observeParams is a Boolean');
       assert.equal(el.observeParams, true, 'default observeParams is true');
+      el.observeParams = false;
+      assert.equal(el.observeParams, true, 'observeParams is always true');
     });
 
     test('default textContent is empty', function () {