Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove dependency on Polymer library #15

Closed
29 of 31 tasks
t2ym opened this issue Mar 1, 2019 · 0 comments
Closed
29 of 31 tasks

[4.0] Remove dependency on Polymer library #15

t2ym opened this issue Mar 1, 2019 · 0 comments

Comments

@t2ym
Copy link
Owner

t2ym commented Mar 1, 2019

[4.0] Remove dependency on Polymer library

Status

Tasks

  • Move @polymer/polymer from dependencies to devDependencies
  • Drop Safari 9 support
  • bower.json with BSD-2-Clause as license
  • Add lit-html dependency
  • Convert to lit-html rendering
    • Remove @polymer/polymer imports
    • Convert properties and observers
  • Make these properties read-only
    • paramAttribute is slot
    • paramFormat is {n}
    • observeParams is true
      • Dummy setter for observeParams
  • Support IE11 and Edge with custom elements v1 polyfill
    • Import a separate polyfill.js from an independent npm module for polyfill.js
      • Import npm package wc-putty
  • Convert tests
    • No Polymer methods
    • Adjust some waits
  • Convert demo
    • Remove intl from extraDependencies in polymer.json
  • Documentation
    • Decent comments
    • API Docs page

Design Issues

  • root property for shadowRoot to imitate a Polymer element
  • Is importMeta property necessary? No

Issues

  • document.createElement('i18n-format') fails with "The result must not have attributes"
    • Fix: Put off setting this.lang in the constructor to connectedCallback()
  • Calling of _setupParams() is too early to collect the expected parameters in the local DOM
    • Fix: Put off this._setupParams() to connectedCallback()
  • ShadyDOM misinterprets target of direct node.appendChild() as shadowRoot
    • Root Cause: If shadowRoot is attached, ShadyDOM unexpectedly performs appendChild() to shadowRoot instead of the node's local DOM
    • Fix: Put off attachShadow() to the first rendering
t2ym added a commit that referenced this issue Mar 1, 2019
t2ym added a commit that referenced this issue Mar 1, 2019
t2ym added a commit that referenced this issue Mar 2, 2019
t2ym added a commit that referenced this issue Mar 2, 2019
t2ym added a commit that referenced this issue Mar 2, 2019
t2ym added a commit that referenced this issue Mar 2, 2019
…upParams() to connectedCallback() and the first rendering, respectively for ShadyDOM and i18n-behavior compatibility
t2ym added a commit that referenced this issue Mar 4, 2019
t2ym added a commit that referenced this issue Mar 16, 2019
@t2ym t2ym closed this as completed in bf85fe3 Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant