-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: T3-upgrade - remove metadataBase + add default og image #1448
Conversation
|
@andreifilip123 is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-fork-andreifilip123-t3-upgrade-t3-oss.vercel.app/ |
* feat: Add upgrade/changelog code (#1420) * Init t3 app * Install shadcn/ui * Add required shadcn/ui components * feat: Add code for * Move octokit inside function * Get more releases * initial workspace config * format and lint * specify eslint paths * some ui changes * ui * lift some state to url * layout fix * theming * favicon * fixy * filter out versions we don't have * sync * uniform function vs const * fix filter --------- Co-authored-by: juliusmarminge <julius0216@outlook.com> * Update README.md * fix styles * expand 1st item by default * importatn?? * rm filter * fix: Minor fixes (#1426) * add a loader * revert force dymaic * fixy * fixy2 * Button -> Link * fix favicon * fixy * rm unnecessary abstraction * feat: Dynamic og image (#1435) * Add og image (screenshot) (#1434) * fix: Add missing versions that were excluded because they contain 0's in them (#1447) * Add og image (screenshot) * fix: getT3Versions was ignoring versions with a 0 in them * chore: tweak some t3-upgrade og styles (#1445) * little bit of a tweak * 👋 * twitter tags * Update route.tsx * Merge branch 'next' into t3-upgrade * chore: T3-upgrade - remove metadataBase + add default og image (#1448) * Add og image (screenshot) * fix: getT3Versions was ignoring versions with a 0 in them * Add back base og image * Remove metadata base * fixup * fix turbo pipelie --------- Co-authored-by: Andrei Filip <andreifilip123@gmail.com> Co-authored-by: Finn <34718806+FinnDore@users.noreply.github.com>
* feat: Add upgrade/changelog code (t3-oss#1420) * Init t3 app * Install shadcn/ui * Add required shadcn/ui components * feat: Add code for * Move octokit inside function * Get more releases * initial workspace config * format and lint * specify eslint paths * some ui changes * ui * lift some state to url * layout fix * theming * favicon * fixy * filter out versions we don't have * sync * uniform function vs const * fix filter --------- Co-authored-by: juliusmarminge <julius0216@outlook.com> * Update README.md * fix styles * expand 1st item by default * importatn?? * rm filter * fix: Minor fixes (t3-oss#1426) * add a loader * revert force dymaic * fixy * fixy2 * Button -> Link * fix favicon * fixy * rm unnecessary abstraction * feat: Dynamic og image (t3-oss#1435) * Add og image (screenshot) (t3-oss#1434) * fix: Add missing versions that were excluded because they contain 0's in them (t3-oss#1447) * Add og image (screenshot) * fix: getT3Versions was ignoring versions with a 0 in them * chore: tweak some t3-upgrade og styles (t3-oss#1445) * little bit of a tweak * 👋 * twitter tags * Update route.tsx * Merge branch 'next' into t3-upgrade * chore: T3-upgrade - remove metadataBase + add default og image (t3-oss#1448) * Add og image (screenshot) * fix: getT3Versions was ignoring versions with a 0 in them * Add back base og image * Remove metadata base * fixup * fix turbo pipelie --------- Co-authored-by: Andrei Filip <andreifilip123@gmail.com> Co-authored-by: Finn <34718806+FinnDore@users.noreply.github.com>
Removed the metadataBase field since the default is good enough. Added back missing base og image
https://nextjs.org/docs/app/api-reference/functions/generate-metadata#default-value