Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscode ext and settings #228

Closed
wants to merge 1 commit into from
Closed

feat: add vscode ext and settings #228

wants to merge 1 commit into from

Conversation

juliusmarminge
Copy link
Member

Add recommended vscode extensions and settings

  • I reviewed linter warnings + errors, resolved formatting, types and other issues related to my work
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Shamefully stolen from @KATT's suggestion in #140.


@juliusmarminge juliusmarminge added the 💬 discussion Issue needs further discussion before decision label Jul 19, 2022
@juliusmarminge
Copy link
Member Author

Putting this up for discussion, both regarding if we include it or not, as well as what extensions we recommend?

@der-ofenmeister
Copy link

Think this goes programmer to programmer? I stick to the default Prettier plugin but someone might use eslint and husky, etc. - so that should be on them to config in their source?

@nexxeln
Copy link
Member

nexxeln commented Jul 20, 2022

Yeah I'm also on the side of not including it tbh. Not everyone uses vscode and I don't want to add a folder to a template which is just going to be deleted

@t3dotgg
Copy link
Member

t3dotgg commented Jul 20, 2022

Two thoughts:

  • This should recommend Tailwind vs code extension
  • Prolly shouldn't recommend prettier b/c opinions

I think this fits in w/ using userId in session, it's common enough that it should probably be included and it doesn't hurt the people who choose not to use VS Code

@gcavanunez
Copy link
Contributor

Though understandable the take on not including prettier due to getting into opinionated territory, wouldn't the out of the box eslint take from Next, the tailwindcss prettier plugin and the example that the create-t3-app uses prettier, be compelling arguments to include prettier?

@juliusmarminge juliusmarminge marked this pull request as draft July 22, 2022 09:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussion Issue needs further discussion before decision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants