Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix none major issues. #38

Closed
wants to merge 26 commits into from
Closed

Fix none major issues. #38

wants to merge 26 commits into from

Commits on Dec 7, 2022

  1. Fix spelling of "self signed" to "self-signed".

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    f1d6a67 View commit details
    Browse the repository at this point in the history

  2. Fix typo of "youtube" to "YouTube".

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    f1d5563 View commit details
    Browse the repository at this point in the history

  3. Fix typo of "double quoted" to "double-quoted".

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    5601aa5 View commit details
    Browse the repository at this point in the history

  4. Fix the formatting of the table to be of markdown standard.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    5ba1c0c View commit details
    Browse the repository at this point in the history

  5. Fixed redundant expressions in regex.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    9d9b3ff View commit details
    Browse the repository at this point in the history

  6. Several 

    "except:
    pass"
Statements were found, at the very least we should be logging the errors.
    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b0c26a9 View commit details
    Browse the repository at this point in the history

  7. Remove more redundant regular expression issues.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    0f776fe View commit details
    Browse the repository at this point in the history

  8. Remove unexpected argument.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    98245ce View commit details
    Browse the repository at this point in the history

  9. Remove unexpected argument.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    d07e767 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary backslashes.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    646569c View commit details
    Browse the repository at this point in the history

  11. Follow PEP rules & re-indented everything with 4 spaces, instead of t… 

    …abs.
    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    2225761 View commit details
    Browse the repository at this point in the history

  12. Remove unused imports.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    95cacaf View commit details
    Browse the repository at this point in the history

  13. Order of exceptions is important. In order to properly catch the time… 

    …d_out error, it's best to put the socket.timeout above the OSError.
    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    19f4b71 View commit details
    Browse the repository at this point in the history

  14. Fix a ton of PEP8 coding style violations.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    7808140 View commit details
    Browse the repository at this point in the history

  15. Reduce the dictionary creation by one line.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    1c0c932 View commit details
    Browse the repository at this point in the history

  16. Class names should be camel case.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    4b6f752 View commit details
    Browse the repository at this point in the history

  17. More pythonic boolean check.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b63ba5a View commit details
    Browse the repository at this point in the history

  18. Remove redundant parentheses

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    eddc599 View commit details
    Browse the repository at this point in the history

  19. Simpily the chained expressions.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    ee212fa View commit details
    Browse the repository at this point in the history

  20. Remove unneeded assignment.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    6fa192c View commit details
    Browse the repository at this point in the history

  21. Major logic bug in core start. This has now been fixed & the timeout … 

    …works as intended.

Essentially, if the core wasn't initialized within the first few milliseconds of startup, because of the way the while loop was constructed it would time out.
    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    3458532 View commit details
    Browse the repository at this point in the history

  22. Remove unneeded imports.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    fdb3daf View commit details
    Browse the repository at this point in the history

  23. Change tabs to spaces.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    73844f2 View commit details
    Browse the repository at this point in the history

  24. Fix too many blank lines.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    9f31f08 View commit details
    Browse the repository at this point in the history

  25. Classes should be CamelCase.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b1dc6cf View commit details
    Browse the repository at this point in the history

  26. Classes should be CamelCase & fix too many blank lines.

    Scot_Survivor committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    3935a6c View commit details
    Browse the repository at this point in the history