Skip to content

Commit

Permalink
🐛 #2 Workaround upstream Atom bug. Remove dependency to atom-config-p…
Browse files Browse the repository at this point in the history
…lus module
  • Loading branch information
t9md committed Jan 26, 2016
1 parent b35550a commit 06ceb89
Show file tree
Hide file tree
Showing 4 changed files with 53 additions and 34 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.9
- Fix: #2 Workaround upstream Atom bug. setting view not appear from Atom v1.4.0.
- Remove dependency to atom-config-plus module.

## 0.1.8 - Refactoring
- Update readme to follow vim-mode's rename from command-mode to normal-mode

Expand Down
6 changes: 2 additions & 4 deletions lib/main.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@
_ = require 'underscore-plus'
settings = require './settings'

Label = null
Label = null
Container = null
Input = null
Input = null

module.exports =
config: settings.config

activate: ->
{Label, Container} = require './label'
Input = require './input'
Expand Down
36 changes: 7 additions & 29 deletions lib/settings.coffee
Original file line number Diff line number Diff line change
@@ -1,30 +1,8 @@
ConfigPlus = require 'atom-config-plus'
module.exports =
scope: 'smalls'

get: (param) ->
atom.config.get("#{@scope}.#{param}")

module.exports = new ConfigPlus 'smalls',
labelChars:
order: 1
type: 'string'
default: ';ABCDEFGHIJKLMNOPQRSTUVWXYZ'
description: "Lower case char not supported"
labelPosition:
order: 2
type: 'string'
default: 'start'
enum: ['start', 'end']
jumpTriggerInputLength:
order: 3
type: 'integer'
minimum: 0
default: 0
description: "0 means disable. If input exceed this length, automatically start jump mode"
flashOnLand:
order: 32
type: 'boolean'
default: true
description: "flash effect on land"
flashType:
order: 35
type: 'string'
default: 'word'
enum: ['match', 'word']
description: 'Range to be flashed'
set: (param, value) ->
atom.config.set("#{@scope}.#{param}", value)
41 changes: 40 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,46 @@
"atom": ">=0.174.0 <2.0.0"
},
"dependencies": {
"atom-config-plus": "^0.1.2",
"underscore-plus": "^1.6.6"
},
"configSchema": {
"labelChars": {
"order": 1,
"type": "string",
"default": ";ABCDEFGHIJKLMNOPQRSTUVWXYZ",
"description": "Lower case characters are not supported"
},
"labelPosition": {
"order": 2,
"type": "string",
"default": "start",
"enum": [
"start",
"end"
]
},
"jumpTriggerInputLength": {
"order": 3,
"type": "integer",
"minimum": 0,
"default": 0,
"description": "0 means disable. If input exceed this length, automatically start jump mode"
},
"flashOnLand": {
"order": 32,
"type": "boolean",
"default": true,
"description": "flash effect on land"
},
"flashType": {
"order": 35,
"type": "string",
"default": "word",
"enum": [
"match",
"word"
],
"description": "Range to be flashed"
}
}
}

0 comments on commit 06ceb89

Please sign in to comment.