Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum supported length of chest names #3909

Open
direwolf420 opened this issue Nov 2, 2023 · 1 comment · May be fixed by #4076
Open

Increase maximum supported length of chest names #3909

direwolf420 opened this issue Nov 2, 2023 · 1 comment · May be fixed by #4076
Labels
NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. Requestor-Player Issues or PRs adding player features or fixing TML gameplay bugs Type: Change/Feature Request Is a request for changes to code base in order to provide improved capabilities

Comments

@direwolf420
Copy link
Contributor

direwolf420 commented Nov 2, 2023

Do you intend to personally contribute/program this feature?

No

I would like to see this change made to improve my experience with

Gameplay as a Player

Description

There's a character limit on how long a chest name can be (20), which can be a problem if

  1. The chest itself has a long name. This is in the realm of possibilities as one vanilla chest has a length of 19, 1 below the limit. If a mod adds a material with a corresponding chest it will say VeryLongMaterialName Chest but gets cut off.
  2. Chat tags are used with modded items - Write [i:2] which displays dirt block, [i:ModName/ItemName] which displays ItemName. You can see immediately that the latter is almost impossible unless the mod and/or the item has a short internal name. This is useful for players that want to have a better visual feedback for item sorting purposes.

Showcase that 2. works with modded items:
chest name is "[i:ThoriumMod/Blood]", exactly 20

The proposal is to increase the limit.

What does this proposal attempt to solve or improve?

Make longer chest names and item tags with modded items possible.

Which (other) solutions should be considered?

Remove the limit entirely

@direwolf420 direwolf420 added NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. Type: Change/Feature Request Is a request for changes to code base in order to provide improved capabilities labels Nov 2, 2023
@github-actions github-actions bot added the Requestor-Player Issues or PRs adding player features or fixing TML gameplay bugs label Nov 2, 2023
@Metratrj
Copy link
Contributor

I would take care of that. /claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. Requestor-Player Issues or PRs adding player features or fixing TML gameplay bugs Type: Change/Feature Request Is a request for changes to code base in order to provide improved capabilities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants