Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExampleDoor broken #4162

Open
JavidPack opened this issue Apr 12, 2024 · 1 comment
Open

ExampleDoor broken #4162

JavidPack opened this issue Apr 12, 2024 · 1 comment
Labels
Resources - ExampleMod Examples to learn modding from

Comments

@JavidPack
Copy link
Collaborator

Version

Latest 1.4.4-stable

OS

Windows

Platform

Steam

This bug affects...

Mod capability as a Modder

Description

ExampleDoor breaks when opened and the tile above the leftmost tile or below the leftmost tile is broken. It also doesn't break when opened to the left and the tiles above or below the hinge are mined.

Basically, the anchors are wrong. I think TileObjectData.newTile.CopyFrom doesn't copy alternates, need to double check. Or the vanilla tiles don't have the right anchors and it doesn't matter since they aren't used for framing purposes.

NVIDIA_Share_2024-04-12_14-47-30.mp4

Log File

No response

Steps to reproduce

No response

Expected Behavior

No response

Actual Behavior

No response

Reproduction frequency

No response

Additional Information

No response
@JavidPack JavidPack added the NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. label Apr 12, 2024
@github-actions github-actions bot added the Requestor-Modders Issues or PRs adding or fixing TML modder API label Apr 12, 2024
@JavidPack JavidPack added Resources - ExampleMod Examples to learn modding from and removed Requestor-Modders Issues or PRs adding or fixing TML modder API NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. labels Apr 12, 2024
@JavidPack
Copy link
Collaborator Author

JavidPack commented Apr 23, 2024 •
edited

Fixed in baf29e9, the vanilla TileObjectData incorrectly places alternates on skipped lines, but that is not correct. Alternates should be in-line with styles, skipped lines are for animation and states. Looks like the vanilla tile ran into the 2048 texture height limit in 1.4.4 and made a change to wrap to a new column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resources - ExampleMod Examples to learn modding from
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JavidPack