Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "Issue Tracking" with wrong GitHub repository #470

Closed
johnmellor opened this issue Aug 27, 2015 · 3 comments
Closed

Adds "Issue Tracking" with wrong GitHub repository #470

johnmellor opened this issue Aug 27, 2015 · 3 comments

Comments

@johnmellor
Copy link

Since commit 6bd2a6a "When Repository is a GH repo, add it to the Issue Tracking metadata.", if I run bikeshed on my fork of whatwg/notifications in order to create a pull request, it adds the following HTML:

+     <dt>Issue Tracking:
+     <dd><a href="https://github.com/johnmellor/notifications/issues/">GitHub</a>

But this is the wrong URL! It should be https://github.com/whatwg/notifications/issues.

It also creates an inconsistency between using https://api.csswg.org/bikeshed/ (which doesn't know about git) and running bikeshed locally.

Based on these two problems, it seems it might be better to go back to explicitly listing these links in the metadata section (indeed the notifications spec already has a !Participate section with this link).

@annevk @beverloo FYI

johnmellor added a commit to johnmellor/notifications that referenced this issue Aug 27, 2015
(and then deleted the spurious Issue Tracking entry; see
speced/bikeshed#470)
@tabatkins
Copy link
Collaborator

You can specify the repository manually with the Repository metadata, if you're running things in a way that produces inconsistent results.

(Notifications has a manual !Participate link to get desired formatting/links, which are different than what Bikeshed generates.)

@johnmellor
Copy link
Author

Is there a way to disable this auto-generated Issue Tracking section and just show the custom !Participate one?

@tabatkins
Copy link
Collaborator

Yeah, you can add Boilerplate: omit feedback-header to the metadata.

(But you still want a Repository: whatwg/notifications entry too, if you ever plan to take advantage of inline GH issues.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants