Fix error handling on download error #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -808,6 +808,8 @@ | |||
| var mime = res.getResponseHeader('Content-Type').replace(/;.*/, ''); | |||
| ext = getFileExtensionFromMime(mime) || ext; | |||
| return createFileEntryFromBlob(res.response, ext); | |||
| }).catch(function (res) { | |||
| throw new Error(res); | |||
There was a problem hiding this comment.
I think this change is not necessary. Without rethrowing an error, promise status becomes an errored.
There was a problem hiding this comment.
Thank you for your review. I fix it.
|
Thank you for your patch. Reviewed :) |
Constellation
added a commit
that referenced
this pull request
Apr 11, 2015
Fix error handling on download error
|
OK, merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/lib/content.js の downloadFile メソッドを使う、"Photo - Upload from Cache" などで、画面上に表示されていても、実際にはファイルがない場合などに、src/lib/utils.js の request メソッドからのエラーが、投げっぱなしジャーマンになってしまっていて、呼び出し元でエラーハンドリングできなかったのを修正。