Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing regex issue where . were not allowed in endpoint path #305

Merged
merged 1 commit into from May 29, 2019

Conversation

sbabayan
Copy link
Contributor

the ednpoint path no longer allowed for periods and tabpy releases contain them (ex - TabPy-0.6) so model deployment was failing

@0golovatyi 0golovatyi merged commit b1d6ded into master May 29, 2019
@0golovatyi 0golovatyi deleted the regex_fix branch May 29, 2019 22:54
Copy link
Contributor

@rxing-tableau rxing-tableau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,

0golovatyi added a commit that referenced this pull request Jul 31, 2019
* Added parameter for configuring timeout for /evaluate. (#298)

* Added configurable timeout.

* Added unit test for custom evaluate timeout.

* Fixed evaluation timeout, added integration tests + additional UT.

* Documentation updates.

* Reverting state.ini.

* Updated file path in server-config.md.

* Fixing pep8 issues.

* Improved timeout error messaging.

* Fixed docs, removed debugging prints.

* Returning HTTP code 408 on eval timeout.

* Querying models through /evaluate causes server hang. (#300)

* Made call_subprocess non-blocking.

* Magic?

* Using native coroutines in EvaluationPlaneHandler.

* Updated docs to reflect timeout limitations.

* Resolved markdownlint issue.

* Back to tornado coroutines.

* Fixed pep8 style.

* fixing regex issue where . were not allowed in endpoint path (#305) (#306)

* adding t-test to pre-deployed models (#312)

* adding t-test to pre-deployed models

* fixed pep8 issues

* import error on ttest and updated successful deployment message for sentiment analysis

* fixed md issues

* fixed endpoint name in integration tests

* refactor redundant code and update md

* Add FAQ.md (#325)

* Update README.md

* Create FAQ.md

* Fix models call via /evaluate in HTTPS (#322)

* Fix models call via /evaluate in HTTPS

* Restore state.ini

* Delete 'Supported Configurations' page (#327)

* Upgrade to Tornado 6 (#328)

* remove asyncronous attribute for coroutines

* Remove dependency on jsonschema

* Fix markdown

* Update setup.py

* Add tornado to travis script

* Add tornado to travis script

* Remove tornado-json dependency

* Update VERSION

* Update CHANGELOG

* Fix pycodestyle warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants