Upgrade to Tornado 6 #328
Merged
Upgrade to Tornado 6 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0golovatyi
requested review from
jnegara,
evaliula,
nmannheimer,
sbabayan and
rxing-tableau
sbabayan
approved these changes
Jul 31, 2019
| - Added t-test model | ||
| - Fixed models call with /evaluate for HTTPS | ||
| - Migrated to Tornado 6 | ||
|
|
There was a problem hiding this comment.
Didn't we also bring over jessica's timeout work?
There was a problem hiding this comment.
Updating changelog...
| @@ -11,4 +11,5 @@ | |||
|
|
|||
| ### AttributeError: module 'tornado.web' has no attribute 'asynchronous' | |||
|
|
|||
| TabPy uses Tornado 5.1.1. To it to your Python environment run `pip install tornado==5.1.1` and then try to start TabPy again. | |||
| TabPy uses Tornado 5.1.1. To it to your Python environment run | |||
There was a problem hiding this comment.
If we are no longer bound to 5.1.1 should we remove this from the documentation?
There was a problem hiding this comment.
Yes, we should. But I'll keep it for now for 2 reasons:
- People may still have the issue using an older version of TabPy, and
- The file itself will be empty before we add any other Q/A there :)
rxing-tableau
approved these changes
Jul 31, 2019
0golovatyi
added a commit
that referenced
this pull request
Jul 31, 2019
* Added parameter for configuring timeout for /evaluate. (#298) * Added configurable timeout. * Added unit test for custom evaluate timeout. * Fixed evaluation timeout, added integration tests + additional UT. * Documentation updates. * Reverting state.ini. * Updated file path in server-config.md. * Fixing pep8 issues. * Improved timeout error messaging. * Fixed docs, removed debugging prints. * Returning HTTP code 408 on eval timeout. * Querying models through /evaluate causes server hang. (#300) * Made call_subprocess non-blocking. * Magic? * Using native coroutines in EvaluationPlaneHandler. * Updated docs to reflect timeout limitations. * Resolved markdownlint issue. * Back to tornado coroutines. * Fixed pep8 style. * fixing regex issue where . were not allowed in endpoint path (#305) (#306) * adding t-test to pre-deployed models (#312) * adding t-test to pre-deployed models * fixed pep8 issues * import error on ttest and updated successful deployment message for sentiment analysis * fixed md issues * fixed endpoint name in integration tests * refactor redundant code and update md * Add FAQ.md (#325) * Update README.md * Create FAQ.md * Fix models call via /evaluate in HTTPS (#322) * Fix models call via /evaluate in HTTPS * Restore state.ini * Delete 'Supported Configurations' page (#327) * Upgrade to Tornado 6 (#328) * remove asyncronous attribute for coroutines * Remove dependency on jsonschema * Fix markdown * Update setup.py * Add tornado to travis script * Add tornado to travis script * Remove tornado-json dependency * Update VERSION * Update CHANGELOG * Fix pycodestyle warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change TabPy is not locked to Tornado 5.1.1 anymore and can use the latest version.