Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to Add Connection Credentials to Publish Workbook #63

Closed
geordielad opened this issue Oct 16, 2016 · 5 comments
Closed

How to Add Connection Credentials to Publish Workbook #63

geordielad opened this issue Oct 16, 2016 · 5 comments

Comments

@geordielad
Copy link
Contributor

I have a workbook with an embedded live connection. On publish I need to add the credential password otherwise the publish fails. This implies that Embed is defaulting to true but I don't want to prompt anyway.

@t8y8
Copy link
Collaborator

t8y8 commented Oct 16, 2016

@benlower bumped into this recently.

We don't currently have a way to set or embed connectionCredentials.
It's technically an option of the publish, so it might be natural to add it as a parameter.

If you're interested in submitting a patch the places to start would be:

  • tableauserverclient/server/endpoint/workbook_endpoint.py
  • tableauserverclient/server/request_factory.py

I did a quick and dirty hack for Ben to test something, but it was hard-coded and inelegant... It just added a connectionCredentials element to the request serializer in request_factory.py always.

@bryanthowell-tableau
Copy link

This is not an enhancement it is a bug that needs to be fixed. This cripples the usefulness of the library for publishing. The only connection type that can publish without credentials is SQL Server with Windows Auth, which is not the most common situation in a SaaS / multi-tenant deployment.

@benlower
Copy link
Contributor

@bryantbhowell thanks for the additional feedback. i'm changing this back to enhancement because that fits our definition ( @RussTheAerialist just clarified things better in contributing.md ).

if this is critical for you, please add the 'Critical' label and we will prioritize. 'cripples' seems a bit overstated here but we get the importance ;)

@benlower benlower added enhancement and removed bug labels Oct 25, 2016
@t8y8
Copy link
Collaborator

t8y8 commented Oct 25, 2016

@geordielad would you be able to post the PR that you shared with me offline?
I think you were pretty close, even if we need to help out with some of the testing parts.

@graysonarts
Copy link
Contributor

This was implemented by @geordielad in #80

bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this issue Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants