add query-tagging attribute to connection #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacalata
force-pushed
the
jac/query-tagging
branch
from
4c679cb
to
e782c29
Compare
jacalata
changed the title
|
Validated this locally using one hyper datasource (cannot change the value for queryTagging) and one postgres connection (attribute successfullyl updated) |
anyoung-tableau
approved these changes
Mar 9, 2023
| @@ -52,6 +69,7 @@ def from_response(cls, resp, ns) -> List["ConnectionItem"]: | |||
| connection_item.server_address = connection_xml.get("serverAddress", None) | |||
| connection_item.server_port = connection_xml.get("serverPort", None) | |||
| connection_item.username = connection_xml.get("userName", None) | |||
| connection_item._query_tagging = connection_xml.get("queryTaggingEnabled", None) | |||
There was a problem hiding this comment.
Just double checking we don't need to use string_to_bool() here like we did on connection_item.embed_password
There was a problem hiding this comment.
good catch. Added that and tests to cover it.
jacalata
added a commit
that referenced
this pull request
Mar 16, 2023
* Implement custom view objects (#1195) * Fix bug in update-datasources before 3.15 (#1203) (fixes #1072) * catch exceptions from ServerInfo (#1204) * add query-tagging attribute to connection (#1202) (add explanation for why it doesn't work on hyper) --------- Co-authored-by: Marwan Baghdad <mrwanbaghdad76@gmail.com> Co-authored-by: jorwoods <jorwoods@users.noreply.github.com> Co-authored-by: Brian Cantoni <bcantoni@salesforce.com> Co-authored-by: TrimPeachu <77048868+TrimPeachu@users.noreply.github.com> Co-authored-by: Stu Tomlinson <stu@nosnilmot.com> Co-authored-by: Jeremy Harris <jercharris89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to figure out how to test this before merging