Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix schedule_item.py for issue 1237 #1239

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

austinpeters-gohealthuccom
Copy link
Contributor

Hotfix for #1237

jacalata and others added 2 commits April 24, 2023 13:08
TableauIDWithMFA added to the user_item model to allow creating users on Tableau Cloud with MFA enabled (tableau#1217)
Run long requests on second thread (tableau#1212)
tableau#1210
tableau#1087
tableau#1058
tableau#456
tableau#1209
update datasource to use bridge (tableau#1224)


Co-authored-by: Tim Payne <47423639+ma7tcsp@users.noreply.github.com>
@salesforce-cla
Copy link

salesforce-cla bot commented Jun 7, 2023

Thanks for the contribution! Before we can merge this, we need @austinpeters-gohealthuccom to sign the Salesforce Inc. Contributor License Agreement.

@austinpeters-gohealthuccom
Copy link
Contributor Author

image

@jacalata
Copy link
Contributor

@austinpeters-gohealthuccom are you able to reformat this for our style checker?

@austinpeters-gohealthuccom
Copy link
Contributor Author

I literally commented out 3 lines and that's it. Means whoever committed the last branch got a bypass.

@gary-beautypie
Copy link

Think it just wants spaces between the # and the commented code?

Spaces in comments? why not
@LennartKloppenburg
Copy link

Hello, I stumbled on this exact issue and I was wondering if there is any scheduled release/merge of this fix?

@jacalata jacalata changed the base branch from master to development July 24, 2023 06:10
@jacalata jacalata changed the base branch from development to master July 24, 2023 06:10
@jacalata jacalata changed the base branch from master to development August 1, 2023 05:26
@jacalata jacalata changed the base branch from development to jac/schedules August 1, 2023 05:29
@jacalata jacalata merged commit 50198d8 into tableau:jac/schedules Aug 1, 2023
17 checks passed
jacalata pushed a commit that referenced this pull request Aug 1, 2023
Co-authored-by: Tim Payne <47423639+ma7tcsp@users.noreply.github.com>
Hotfix for #1237
jacalata added a commit that referenced this pull request Aug 1, 2023
* Hotfix schedule_item.py for issue 1237 (#1239)
* Remove duplicate assignments to fields (#1244)

Co-authored-by: Tim Payne <47423639+ma7tcsp@users.noreply.github.com>
Co-authored-by: Austin <110413815+austinpeters-gohealthuccom@users.noreply.github.com>
Co-authored-by: Yasuhisa Yoshida <syou6162@gmail.com>
jacalata added a commit that referenced this pull request Sep 22, 2023
* fix: TableauIDWithMFA added to the user_item model to allow creating users on Tableau Cloud with MFA enabled (#1216)
* fix: make project optional in datasources #1210
* fix: allow setting timeout on workbook endpoint #1087
* fix: can't certify datasource on publish #1058 
* fix filter in operator spaces bug (#1259)
* fix: remove logging configuration from TSC (#1248)
* Hotfix schedule_item.py for issue 1237 (#1239), Remove duplicate assignments to fields (#1244)
* Fix shared attribute for custom views (#1280)

New functionality
* enable filtering for Excel downloads #1209, #1281
* query view by content url #456  
* update datasource to use bridge (#1224)
* Add JWTAuth, add repr using qualname
* Add publish samples attribute (#1264)
* add support for custom schedules in TOL (#1273)
* Enable asJob for group update (#1276)


Co-authored-by: Tim Payne <47423639+ma7tcsp@users.noreply.github.com>
Co-authored-by: Lars Breddemann <139097050+LarsBreddemann@users.noreply.github.com>
Co-authored-by: jorwoods <jorwoods@users.noreply.github.com>
Co-authored-by: Austin <110413815+austinpeters-gohealthuccom@users.noreply.github.com>
Co-authored-by: Yasuhisa Yoshida <syou6162@gmail.com>
Co-authored-by: Brian Cantoni <bcantoni@salesforce.com>
Co-authored-by: a-torres-2 <142839181+a-torres-2@users.noreply.github.com>
Co-authored-by: Łukasz Włodarczyk <lukasz@pushmetrics.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants