Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Unauthorized Error in 0.29 #1345

Merged
merged 4 commits into from
Jan 19, 2024
Merged

fix Unauthorized Error in 0.29 #1345

merged 4 commits into from
Jan 19, 2024

Conversation

jacalata
Copy link
Contributor

@jacalata jacalata commented Jan 19, 2024

This fixes #1342 and #1339
The retry code was being triggered wrongly so the requests were made twice.

Validated against live server with the hello_universe sample, and also by running tabcmd built with the fixed version of tsc.

1. remove metrics since feature is disabled
2. update VALID_INTERVALS to include all values returned from the server
Copy link

github-actions bot commented Jan 19, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
tableauserverclient
   __init__.py40100% 
   _version.py279163163 42%
   config.py50100% 
   datetime_helpers.py2511 96%
   exponential_backoff.py200100% 
   filesys_helpers.py310100% 
   namespace.py2633 88%
tableauserverclient/helpers
   __init__.py10100% 
   headers.py130100% 
   logging.py20100% 
   strings.py2711 96%
tableauserverclient/models
   __init__.py360100% 
   column_item.py553232 42%
   connection_credentials.py351111 69%
   connection_item.py771010 87%
   custom_view_item.py11999 92%
   data_acceleration_report_item.py5411 98%
   data_alert_item.py15933 98%
   database_item.py2033434 83%
   datasource_item.py2401111 95%
   dqw_item.py10455 95%
   exceptions.py40100% 
   favorites_item.py5788 86%
   fileupload_item.py190100% 
   flow_item.py1491010 93%
   flow_run_item.py720100% 
   group_item.py8133 96%
   interval_item.py1833434 81%
   job_item.py1771212 93%
   metric_item.py1301212 91%
   pagination_item.py340100% 
   permissions_item.py7577 91%
   project_item.py1443131 78%
   property_decorators.py961818 81%
   reference_item.py190100% 
   revision_item.py6033 95%
   schedule_item.py20566 97%
   server_info_item.py3955 87%
   site_item.py6101212 98%
   subscription_item.py10333 97%
   table_item.py1181818 85%
   tableau_auth.py712626 63%
   tableau_types.py2311 96%
   tag_item.py160100% 
   target.py60100% 
   task_item.py5722 96%
   user_item.py2771717 94%
   view_item.py1561515 90%
   webhook_item.py660100% 
   workbook_item.py2551616 94%
tableauserverclient/server
   __init__.py80100% 
   exceptions.py40100% 
   filter.py2111 95%
   pager.py3744 89%
   query.py1092121 81%
   request_factory.py902136136 85%
   request_options.py23744 98%
   server.py1631717 90%
   sort.py60100% 
tableauserverclient/server/endpoint
   __init__.py270100% 
   auth_endpoint.py761212 84%
   custom_views_endpoint.py6822 97%
   data_acceleration_report_endpoint.py210100% 
   data_alert_endpoint.py972525 74%
   databases_endpoint.py1033333 68%
   datasources_endpoint.py3064141 87%
   default_permissions_endpoint.py4655 89%
   dqw_endpoint.py431616 63%
   endpoint.py1671616 90%
   exceptions.py6066 90%
   favorites_endpoint.py952222 77%
   fileuploads_endpoint.py510100% 
   flow_runs_endpoint.py631010 84%
   flows_endpoint.py2156060 72%
   groups_endpoint.py1071111 90%
   jobs_endpoint.py5888 86%
   metadata_endpoint.py881414 84%
   metrics_endpoint.py5888 86%
   permissions_endpoint.py4655 89%
   projects_endpoint.py1272222 83%
   resource_tagger.py401010 75%
   schedules_endpoint.py1001111 89%
   server_info_endpoint.py351010 71%
   sites_endpoint.py1262828 78%
   subscriptions_endpoint.py581515 74%
   tables_endpoint.py1023939 62%
   tasks_endpoint.py6577 89%
   users_endpoint.py1271515 88%
   views_endpoint.py1241010 92%
   webhooks_endpoint.py571111 81%
   workbooks_endpoint.py3304242 87%
TOTAL9390124087% 

Copy link
Contributor

@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests with my scripts are all working again (no exception at sign out)

@jacalata jacalata merged commit bae1d83 into development Jan 19, 2024
35 checks passed
@jacalata jacalata deleted the jac/fix-0-29 branch January 19, 2024 19:03
@BobDu
Copy link

BobDu commented Jan 23, 2024

Could we possibly release a version 0.30 to address this significant bug at the earliest convenience?
@bcantoni @jacalata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants