Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGI Removal #1346

Merged
merged 5 commits into from
Jan 22, 2024
Merged

CGI Removal #1346

merged 5 commits into from
Jan 22, 2024

Conversation

markm-io
Copy link
Contributor

Removed cgi due to deprecation and updated to use email.message.Message instead.

Copy link

Thanks for the contribution! Before we can merge this, we need @markm-io to sign the Salesforce Inc. Contributor License Agreement.

@bcantoni
Copy link
Contributor

@markm-io thanks for putting this together. There are 2 other places the CGI module is used. Would you mind updating flows_endpoint.py and workbooks_endpoint.py here as well?

Also, you'll need to fix those black and mypy errors before this PR will go green. You can see the steps explained more in the dev guide.

@markm-io
Copy link
Contributor Author

@markm-io thanks for putting this together. There are 2 other places the CGI module is used. Would you mind updating flows_endpoint.py and workbooks_endpoint.py here as well?

Also, you'll need to fix those black and mypy errors before this PR will go green. You can see the steps explained more in the dev guide.

All files have been updates and both black and mypy commands have been run with corrections made.

@jacalata jacalata merged commit 969922b into tableau:development Jan 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants