Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of Pager results #1370

Merged
merged 2 commits into from
May 23, 2024

Conversation

bcantoni
Copy link
Contributor

In some cases, Tableau Server might have a different between the advertised total number of object and the actual number returned via the Pager.

This change adds one more check to prevent errors from happening in these situations.

Fixes #1304

In some cases, Tableau Server might have a different between the advertised total
number of object and the actual number returned via the Pager.

This change adds one more check to prevent errors from happening in these
situations.

Fixes #1304
Copy link

github-actions bot commented Apr 27, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
tableauserverclient
   __init__.py40100% 
   _version.py279163163 42%
   config.py50100% 
   datetime_helpers.py2511 96%
   exponential_backoff.py200100% 
   filesys_helpers.py310100% 
   namespace.py2633 88%
tableauserverclient/helpers
   __init__.py10100% 
   headers.py1388 38%
   logging.py20100% 
   strings.py2711 96%
tableauserverclient/models
   __init__.py370100% 
   column_item.py553232 42%
   connection_credentials.py351111 69%
   connection_item.py771010 87%
   custom_view_item.py11999 92%
   data_acceleration_report_item.py5411 98%
   data_alert_item.py15933 98%
   data_freshness_policy_item.py1561515 90%
   database_item.py2033434 83%
   datasource_item.py2401111 95%
   dqw_item.py10455 95%
   exceptions.py40100% 
   favorites_item.py5788 86%
   fileupload_item.py190100% 
   flow_item.py1491010 93%
   flow_run_item.py720100% 
   group_item.py8133 96%
   interval_item.py1833434 81%
   job_item.py1771212 93%
   metric_item.py1301212 91%
   pagination_item.py340100% 
   permissions_item.py7577 91%
   project_item.py1443131 78%
   property_decorators.py991818 82%
   reference_item.py190100% 
   revision_item.py6033 95%
   schedule_item.py20666 97%
   server_info_item.py3955 87%
   site_item.py6101212 98%
   subscription_item.py10333 97%
   table_item.py1181818 85%
   tableau_auth.py712626 63%
   tableau_types.py2311 96%
   tag_item.py160100% 
   target.py60100% 
   task_item.py5722 96%
   user_item.py2771717 94%
   view_item.py1781515 92%
   webhook_item.py660100% 
   workbook_item.py2751616 94%
tableauserverclient/server
   __init__.py80100% 
   exceptions.py40100% 
   filter.py2111 95%
   pager.py3744 89%
   query.py1092121 81%
   request_factory.py966138138 86%
   request_options.py26744 99%
   server.py1641717 90%
   sort.py60100% 
tableauserverclient/server/endpoint
   __init__.py280100% 
   auth_endpoint.py761212 84%
   custom_views_endpoint.py6822 97%
   data_acceleration_report_endpoint.py210100% 
   data_alert_endpoint.py972525 74%
   databases_endpoint.py1033333 68%
   datasources_endpoint.py3084141 87%
   default_permissions_endpoint.py4655 89%
   dqw_endpoint.py431616 63%
   endpoint.py1671616 90%
   exceptions.py6066 90%
   favorites_endpoint.py952222 77%
   fileuploads_endpoint.py510100% 
   flow_runs_endpoint.py631010 84%
   flow_task_endpoint.py2333 87%
   flows_endpoint.py2176060 72%
   groups_endpoint.py1071111 90%
   jobs_endpoint.py5888 86%
   metadata_endpoint.py881414 84%
   metrics_endpoint.py5888 86%
   permissions_endpoint.py4655 89%
   projects_endpoint.py1272222 83%
   resource_tagger.py401010 75%
   schedules_endpoint.py1001111 89%
   server_info_endpoint.py351010 71%
   sites_endpoint.py1262828 78%
   subscriptions_endpoint.py581515 74%
   tables_endpoint.py1023939 62%
   tasks_endpoint.py6577 89%
   users_endpoint.py1271515 88%
   views_endpoint.py1241010 92%
   webhooks_endpoint.py571111 81%
   workbooks_endpoint.py3354242 87%
TOTAL9721126887% 

@bcantoni
Copy link
Contributor Author

bcantoni commented May 3, 2024

It took a little work but I found an internal QA server that exhibited the reported bug with paginating through subscriptions with TSC v0.30 (and also v0.29). Testing with this branch worked correctly.

@bcantoni bcantoni requested a review from jacalata May 3, 2024 01:35
@jacalata jacalata merged commit 6687d2a into development May 23, 2024
25 of 26 checks passed
@jacalata jacalata deleted the 1304-improve-pager-error-handling branch May 23, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants