Jorwoods/combining permissionsrules #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for combining
PermissionRulesif the grantee type and id matches. The user of TSC can bitwise or|two or more rules together to keep the most permissive of rules. The user can bitwise and&them together to keep the most restrictive of rules.Incidentally also adds the ability to check if two
ReferenceItems are equal.Allow | Allow = Allow
Allow | None = Allow
Allow | Deny = Allow
None | Deny = None
Deny | Deny = Deny
Allow & Allow = Allow
Allow & None = None
Allow & Deny = Deny
None & Deny = Deny
Deny & Deny = Deny