Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add usage to views.get_by_id #1383

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

jorwoods
Copy link
Contributor

Closes #1322

Adds the ability to retrieve usage statistics when calling get_by_id for the Views endpoint.

@bcantoni
Copy link
Contributor

bcantoni commented Jun 4, 2024

@jorwoods I was going to test this, but I think it's missing adding total_views under models/view_item.py?

@jorwoods
Copy link
Contributor Author

jorwoods commented Jun 4, 2024

The total_views property already exists under the ViewItem. Getting usage information was already supported by server.views.get, this really just adds it to the get_by_id.

Copy link
Contributor

@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see it now! It was a problem on my side when testing. Changes look good!

Copy link
Contributor

@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also submitted a docs bug to get this parameter added to our REST API docs!

@jacalata jacalata merged commit e6a709a into tableau:development Jun 20, 2024
21 checks passed
@jorwoods jorwoods deleted the jorwoods/view_id_usage branch June 20, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants