Add materialized views settings support for workbooks/sites #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baixin137
commented
Jan 18, 2019
baixin137
commented
- Added materialized views settings to workbook/site item class
- Added a sample python script to enable materialized views for workbooks/sites
added 9 commits
January 17, 2019 16:48
… script to update these settings
xinsui
reviewed
Jan 22, 2019
…server-client-python into materialize-workbooks
shinchris
reviewed
Jan 24, 2019
shinchris
reviewed
Jan 24, 2019
gaoang2148
reviewed
Jan 24, 2019
There was a problem hiding this comment.
LGTM overall! One comment I have is to add some more comments in samples/materialize_workbooks.py for external users. Some places I think is assuming users to have good knowledge about Tableau Server. E.g. the recursion in find_project_path is pretty neat for nested project, but external users might not get it at first sight.
added 2 commits
January 23, 2019 18:40
…by_content_url to correct rest api version
…script to update/check on materialized views settings
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.