Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Schedules Support Round 2 #48

Merged
merged 17 commits into from Oct 7, 2016
Merged

Adding Schedules Support Round 2 #48

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
03e8ce3
added ability to query and delete schedules
shinchris Sep 13, 2016
312a1c7
added ability to create and update schedules
shinchris Sep 16, 2016
b32a632
Merge branch 'development' of https://github.com/tableau/server-clien…
t8y8 Oct 2, 2016
0adb03f
Resubmitting #30 with a few changes.
t8y8 Oct 3, 2016
66e1793
Use new validation decorators
t8y8 Oct 4, 2016
0342bed
Refactoring intervals into their own classes - Round 1
t8y8 Oct 5, 2016
bb9ff8f
And fix pep8
t8y8 Oct 5, 2016
34457b3
Refactor intervals - Round 2. Added validation back
t8y8 Oct 5, 2016
f4490fb
Round 3, refactoring setters on the IntervalTypes. Import cleanup
t8y8 Oct 5, 2016
79271a1
Fix sample
t8y8 Oct 5, 2016
b710d9d
Round 4. Fully remove IntervalItem base class. Now it's just an enum …
t8y8 Oct 6, 2016
46cc1d0
Minor cleanup
t8y8 Oct 6, 2016
fd17154
Respond to CR feedback.
t8y8 Oct 6, 2016
371b6f9
Final round of cleanup, I think
t8y8 Oct 7, 2016
28ebb9e
Remove frequency and interval_occurence from public API
t8y8 Oct 7, 2016
c330687
More cleanup
t8y8 Oct 7, 2016
d7add3a
Move the interval-occurence tuple logic into a function just for the …
t8y8 Oct 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 10 additions & 23 deletions tableauserverclient/models/schedule_item.py
View file
Open in desktop
@@ -1,5 +1,6 @@
import xml.etree.ElementTree as ET
from .interval_item import IntervalItem
from .property_decorators import property_is_enum, property_is_boolean, property_not_empty, property_not_nullable
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove the imports I'm not using, copy/paste error

from .. import NAMESPACE


Expand Down Expand Up @@ -49,12 +50,9 @@ def execution_order(self):
return self._execution_order

@execution_order.setter
@property_is_enum(ExecutionOrder)
def execution_order(self, value):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this with @LGraber 's decorators still

if value and not hasattr(ScheduleItem.ExecutionOrder, value):
error = "Invalid execution order defined: {}.".format(value)
raise ValueError(error)
else:
self._execution_order = value
self._execution_order = value

@property
def frequency(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to access the interval's frequency

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the frequency is on the schedule, the interval is the frequencyDetail

http://onlinehelp.tableau.com/samples/en-us/rest_api/ts-api_2_3.xsd

Expand All @@ -69,12 +67,9 @@ def name(self):
return self._name

@name.setter
@property_not_nullable
def name(self, value):
if not value:
error = "Name must be defined."
raise ValueError(error)
else:
self._name = value
self._name = value

@property
def next_run_at(self):
Expand All @@ -97,27 +92,19 @@ def schedule_type(self):
return self._schedule_type

@schedule_type.setter
@property_is_enum(Type)
@property_not_nullable
def schedule_type(self, value):
if not value:
error = "Schedule type must be defined."
raise ValueError(error)
elif not hasattr(ScheduleItem.Type, value):
error = "Invalid schedule type defined: {}.".format(value)
raise ValueError(error)
else:
self._schedule_type = value
self._schedule_type = value

@property
def state(self):
return self._state

@state.setter
@property_is_enum(State)
def state(self, value):
if not hasattr(ScheduleItem.State, value):
error = "Invalid state defined."
raise ValueError(error)
else:
self._state = value
self._state = value

@property
def updated_at(self):
Expand Down