Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic tests for request making methods #91

Merged
merged 1 commit into from Nov 2, 2016

Conversation

t8y8
Copy link
Collaborator

@t8y8 t8y8 commented Oct 31, 2016

A very early and very primitive set of tests that would have covered #88 .

Basically, make a request (we match on any endpoint because the response doesn't matter) then peek into the request object and assert it all came together correctly.

/cc @RussTheAerialist

Copy link
Contributor

@graysonarts graysonarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this kind of test will have definitely caught the problem I introduced. Thanks for doing this!

@t8y8 t8y8 merged commit 114922b into tableau:development Nov 2, 2016
@t8y8 t8y8 deleted the 88-request-tests branch November 2, 2016 21:06
t8y8 added a commit to t8y8/server-client-python that referenced this pull request Jun 28, 2017
* GET and POST tests verify headers, body, and query strings coming from `Endpoint`
t8y8 added a commit to t8y8/server-client-python that referenced this pull request Jun 28, 2017
* GET and POST tests verify headers, body, and query strings coming from `Endpoint`
bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this pull request Dec 28, 2023
bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants