Add deprecation warning to site setter too #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know how Ben's changes got back in the development branch -- I did a hard reset against the cleaned branch, but that's what's causing my test failures. Looks like the sample is still there |
|
I don't know either, but try to pull development into your bugfix branch and try again? |
t8y8
force-pushed
the
fix-depreate-site-setter
branch
from
f9bd617
to
624f578
Compare
|
This is age old and trivial, I'm just gonna finally push it now that it's rebased and tests are passing :) |
bryceglarsen
pushed a commit
to bryceglarsen/server-client-python
that referenced
this pull request
Dec 28, 2023
Issue tableau#96: Add port support We now support reading and setting the port attribute on connections. If you set the port attribute to None it will remove it entirely. Small change to tests so that they don't have side effects between test cases.
bryceglarsen
pushed a commit
to bryceglarsen/server-client-python
that referenced
this pull request
Dec 28, 2023
Issue tableau#96: Add port support We now support reading and setting the port attribute on connections. If you set the port attribute to None it will remove it entirely. Small change to tests so that they don't have side effects between test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.