Jac/more mypy checks #287
Open
Jac/more mypy checks #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove python 3.7
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group) * Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace) * clarified help content for extract-encryption and some other not-implemented options * added tests for all valid publish command options * error log cleanup: better stacktrace, less repetition
Also change a print statement to log statement
also add unit test
(cherry picked from commit ef93fff)
* skip .po and .properties files * pin pyinstaller to 5.13 Co-authored-by: Andy Young <90729701+anyoung-tableau@users.noreply.github.com>
* test robustness - add skip-connection-check so it can run against local server - fix bug revealed where it was confused by the Default server - fix asset names to go with assets in repo - fail fast if publishing fails (because all the following tests will also fail) - fail cleanly if you forget to enter any command * add content in the tests\assets dir, update gitignore * remove import being added back * format w black * specify version of black expected
* Fix logic in test_list_sites E2E test * Update dependencies - move TSC pin to latest 0.31 - relax urllib3 version range to avoid conflict w/TSC
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group) * Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace) * clarified help content for extract-encryption and some other not-implemented options * added tests for all valid publish command options * error log cleanup: better stacktrace, less repetition
Also change a print statement to log statement
(cherry picked from commit ef93fff)
Update company name to Salesforce
A lot of changes to the dodo code, but it's mostly a) handling file paths better b) moving the 'merge files' step before the 'generate po' step c) automating some processing I did manually in the past to remove lines that caused problems
There is a group of strings I appear to have added manually that was deleted with the new loc file dump, and another group of string keys that are used in code and don't appear in properties. Adding here to not lose them, but hope to find they are not necessary.
Add copyright, fix handling of strings with '=' in them
these should make the process of updating strings straightforward in the future, and create intermediate outputs to help with debugging if it is not. Validated with the windows package only so far.
Removed a duplicate string from extras.properties Adding the newly generated .mo files
and remove test on a string that no longer exists
- replace double quotes with single - cleaner file globs - remove no-op encoding - fix copyright
add auth type TableauIDWithMFA
Also add to automation a step where I replaced two-single-quote chars with one.
Add a large number of new localized strings
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group) * Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace) * clarified help content for extract-encryption and some other not-implemented options * added tests for all valid publish command options * error log cleanup: better stacktrace, less repetition
Also change a print statement to log statement
(cherry picked from commit ef93fff)
also add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabled 'check_untyped_defs' so that methods without explicit type identifiers are still checked by mypy.
Found a number of places that this didn't work, so created comments to make an exception where needed.
Some minor refactoring needed to get types or null cases recognized, and run_command method was changed from static to class method.