Fixes to tablename being parsed from query #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awmuncy
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
This looks good. The overhead of this change also lends weight to @carsonfarmer's suggestion that we not do any validation of their query SDK side.
Yeah, it's starting to feel like the RegExp is getting unwieldy. Maybe we want to remove that check entirely? |
No objections, I think it's probably a good idea. |
This was referenced Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries like:
INSERT INTO "Test_1" (colname) Values ('val6');INSERT INTO test_1(colname) Values ('val6');were not being permitted because of the regex check for table id