Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dark mode issue for Tomselect #1024

Closed
kevinpapst opened this issue Feb 6, 2022 · 7 comments
Closed

[BUG] Dark mode issue for Tomselect #1024

kevinpapst opened this issue Feb 6, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@kevinpapst
Copy link
Collaborator

Describe the bug

Some issues with Tomselect exist in dark mode at https://preview.tabler.io/form-elements.html:

  • Selected text is not visible
  • Not possible to identify optgroups (adding an example in one of the demo dropdowns would be great!)

Bildschirmfoto 2022-02-06 um 18 03 42

@kevinpapst kevinpapst added the bug Something isn't working label Feb 6, 2022
@Nejcc
Copy link
Contributor

Nejcc commented Feb 6, 2022

Why this dropdown is not full width?

rjd22 added a commit that referenced this issue Mar 24, 2022
rjd22 added a commit that referenced this issue Mar 24, 2022
@rjd22
Copy link
Collaborator

rjd22 commented Mar 24, 2022

@kevinpapst would it be possible to make an code example of the optgroups for me? I might fix that too.

@rjd22 rjd22 closed this as completed in d4097c4 Apr 11, 2022
@rjd22 rjd22 reopened this Apr 11, 2022
@rjd22
Copy link
Collaborator

rjd22 commented Apr 11, 2022

Outgroups still need to be fixed.

@kevinpapst
Copy link
Collaborator Author

Yeah sorry, didn't follow the bug. Main point is fixed.

The optgroup is still white, but that is less problematic:

Bildschirmfoto 2022-07-30 um 13 14 53

@rjd22
Copy link
Collaborator

rjd22 commented Jul 30, 2022

If you're willing and have time to make an PR for it I will gladly merge it ;).

@kevinpapst
Copy link
Collaborator Author

I'd be happy to invest more, but I am really missing the communication how the project is going forward. Is the dark mode replaced by the Bootstrap native dark mode that is now in alpha/beta? Is it even worth investing any time into the dark mode right now?

How many breaking changes can we expect in the beta cycle (usually only used for bug fixing and not for introducing major changes) before a stable release? Not that this has anything to do with this issue right here, more of a general uncertainty that holds me back.

@rjd22
Copy link
Collaborator

rjd22 commented Jul 30, 2022

@codecalm would be the one to answer correctly but I would guess that the original dark mode will not be replaced with Bootstrap dark mode soon.

It would be an good idea to focus releasing a stable version and improving tabler on a feature by feature basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants