Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multiple bugs after Bootstrap update #1145

Closed
kevinpapst opened this issue Jun 9, 2022 · 5 comments
Closed

[BUG] Multiple bugs after Bootstrap update #1145

kevinpapst opened this issue Jun 9, 2022 · 5 comments

Comments

@kevinpapst
Copy link
Collaborator

kevinpapst commented Jun 9, 2022

Not sure if this is related to the "Bootstrap beta" PR, but it was working just a couple of days ago and this here was the biggest change lately. So I assume this update broke several things, one of it was modals:
https://preview.tabler.io/docs/modals.html

Unreadable in both dark and normal mode now, e.g.
Bildschirmfoto 2022-06-07 um 21 12 56

I can look for more quirks if you like. You know: I saw the PR when you opened it and was about to ask for a new release, but you were even quicker with the merge 😁

Here is another glitch:
Bildschirmfoto 2022-06-07 um 21 21 26

I'd like to offer my help for the future. I don't mind if you ping me directly and call out for help with testing. I can only speak for myself, but I am available and happy to support in that way.

Or is this just a misunderstanding on my end and https://preview.tabler.io simply outdated?

Originally posted by @kevinpapst in #1131 (comment)

@kevinpapst kevinpapst changed the title Bootstrap update caused issues [BUG] Multiple bugs after Bootstrap update Jun 21, 2022
@dheineman
Copy link
Contributor

@kevinpapst I cannot seem to reproduce the second glitch where the button text is not visible. Are you still seeing this and if so, do you have a specific way to reproduce it?

@kevinpapst
Copy link
Collaborator Author

Interesting, now that you answered I tried in other browsers (Firefox works) and maybe it is a Safari only bug.

I made this screenshot right now:
Bildschirmfoto 2022-07-30 um 13 02 20

So nothing special, just open the page.

@kevinpapst
Copy link
Collaborator Author

Firefox says this:
Bildschirmfoto 2022-07-30 um 13 05 02
Maybe the variable --tblr-color-text is missing and different browsers handle that problem in different ways?

@dheineman
Copy link
Contributor

Maybe the variable --tblr-color-text is missing and different browsers handle that problem in different ways?

yeah i just came to the same conclusion.

It was indeed caused by the bootstrap 5.2.0-beta1 PR but i am unsure if and where this variable should be defined so i will leave this one to @codecalm :)

@kevinpapst
Copy link
Collaborator Author

Thanks for helping to investigate the issue! I opened a follow up bug, so it is easier for @codecalm to understand it:
#1177

I am closing here, as you fixed the modals already 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants