Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added popover docs page #1157

Merged
merged 2 commits into from
Jun 30, 2022
Merged

added popover docs page #1157

merged 2 commits into from
Jun 30, 2022

Conversation

kevinpapst
Copy link
Collaborator

@kevinpapst kevinpapst commented Jun 21, 2022

This adds an example page to showcase Popovers:
https://getbootstrap.com/docs/5.0/components/popovers/

Currently there is a bug in dark mode, probably due to #1145, which I initially wanted to work on:
Bildschirmfoto 2022-06-21 um 23 18 21

But my frontend voodoo is not good enough.

The component is already using variables, but those seem to be defined for light only:
Bildschirmfoto 2022-06-21 um 23 19 19

Anyway, I wanted to add the docs page in this PR only:

Bildschirmfoto 2022-06-21 um 23 21 34

The content was improved and one example added after taking the screenshot, please check the Vercel deployment:
https://tabler-git-fork-kevinpapst-popover-tabler-ui.vercel.app/docs/popover.html

@vercel
Copy link

vercel bot commented Jun 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tabler ✅ Ready (Inspect) Visit Preview Jun 21, 2022 at 9:27PM (UTC)

@rjd22
Copy link
Collaborator

rjd22 commented Jun 30, 2022

@kevinpapst looks great, thank you

@rjd22 rjd22 merged commit 708c70b into tabler:main Jun 30, 2022
@kevinpapst kevinpapst deleted the popover branch June 30, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants