Fix rendering of modal examples on docs page #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kevinpapst
reviewed
Jul 29, 2022
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for modal bugs reported in #1145
Bootstrap 5.2 moved to using CSS variables for modals (twbs/bootstrap#36060) which are set on the
modalclass. As this class is not included in the sample code, the other modal classes (likemodal-dialogandmodal-content) could not find the correct variables to set things like the padding/margin etc.This PR will add the
modalclass to the sample code as it is required for both the end user and correctly rendering the modals in the documentation.